• gdeepti's avatar
    [wasm] Do not unregister an ArrayBuffer if it is already external · e2fc979e
    gdeepti authored
     - Currently if GrowMemory is called with pages = 0, an attempt is made to
       unregister the ArrayBuffer even if it is external. Cleanup so all Detaching
       of ArrayBuffer is centralized to one method, and can only be called fromJS.
     - Gate creating WeakHandles to the memory on the buffer having guard pages
       enabled. Currently creating a WeakHandle is gated only on if the buffer
       is_external true. If a buffer is marked is_external = true to begin with,
       the WeakHandle is created and the Finalizer is run causing the program to
       crash.
    
    BUG=chromium:717647
    
    Review-Url: https://codereview.chromium.org/2867233002
    Cr-Commit-Position: refs/heads/master@{#45238}
    e2fc979e
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...