• mstarzinger's avatar
    Revert of Decompiler improvements. (patchset #2 id:20001 of... · e2ce4681
    mstarzinger authored
    Revert of Decompiler improvements. (patchset #2 id:20001 of https://codereview.chromium.org/1177123002/)
    
    Reason for revert:
    Code printout has become unreadable. Offsets are printed in decimal numbers everywhere else. This is inconsistent with the rest of the code-base. Some examples are tables for deoptimization data, safepoints and exception handlers. I would be fine with this change if _all_ tracing would be adapted. But there are _many_ places to touch.
    
    Original issue's description:
    > Decompiler improvements.
    >
    > The main motivation is simplifying profiling activities:
    >
    > 1) Use hex instead of decimal for offsets, just like perf does. This
    > affects --print-opt-code
    >
    > 2) When printing block information, indicate loop information: if
    > block is header, where the end is; if block is in a loop, where the
    > loop starts. This affects --code-comments.
    >
    > Using --print-opt-code --code-comments, and cross-referencing with data
    > obtained from perf, one may now find the block a hotspot belongs to
    > without needing to do hex2dec/dec2hex conversions. Once found, loop info
    > is available locally, on the block.
    >
    > BUG=
    >
    > Committed: https://crrev.com/32f4bd659d38eb5485eedb1d0dd236ff1bdc01d5
    > Cr-Commit-Position: refs/heads/master@{#28964}
    
    TBR=jarin@chromium.org,stichnot@chromium.org,jvoung@chromium.org,mtrofin@chromium.org
    NOPRESUBMIT=true
    NOTREECHECKS=true
    NOTRY=true
    BUG=
    
    Review URL: https://codereview.chromium.org/1188093002
    
    Cr-Commit-Position: refs/heads/master@{#29046}
    e2ce4681
Name
Last commit
Last update
benchmarks Loading commit data...
build Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
Makefile.nacl Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...