• Clemens Backes's avatar
    [wasm] Fix death tests with signal handling · e28f0cc4
    Clemens Backes authored
    The previous setup of the test was suboptimal and could easily hide
    bugs. Since the whole test body was wrapped in an ASSERT_DEATH call
    (without checking any message of the crash), any CHECK failure inside
    the test body would make the test pass.
    
    This CL leverages the fact that in our setup the "death test style" is
    set to "threadsafe" anyway, so the process that is forked for the death
    test just runs the whole test body including the single death test of
    interest, and the parent checks that it indeed crashes. This allows us
    to undo our previous setup and just include death test assertions
    regularly in the test body. By checking that the child process fails
    exactly between two print statements (around the write access) we ensure
    that we observe the crash we intend to observe.
    
    R=jkummerow@chromium.org
    CC=​mpdenton@chromium.org
    
    Bug: v8:11974
    Cq-Include-Trybots: luci.v8.try:v8_mac_arm64_rel_ng
    Cq-Include-Trybots: luci.v8.try:v8_mac_arm64_dbg_ng
    Change-Id: I293079ae2dbcbe154bef91314ed08cab567f4d18
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3151965Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#76814}
    e28f0cc4
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
assembler Loading commit data...
base Loading commit data...
codegen Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
date Loading commit data...
debug Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
heap Loading commit data...
interpreter Loading commit data...
libplatform Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parser Loading commit data...
profiler Loading commit data...
regexp Loading commit data...
regress Loading commit data...
runtime Loading commit data...
strings Loading commit data...
tasks Loading commit data...
torque Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
BUILD.gn Loading commit data...
DEPS Loading commit data...
run-all-unittests.cc Loading commit data...
test-helpers.cc Loading commit data...
test-helpers.h Loading commit data...
test-utils.cc Loading commit data...
test-utils.h Loading commit data...
testcfg.py Loading commit data...
unittests.status Loading commit data...