• Clemens Backes's avatar
    [wasm] Fix death tests with signal handling · e28f0cc4
    Clemens Backes authored
    The previous setup of the test was suboptimal and could easily hide
    bugs. Since the whole test body was wrapped in an ASSERT_DEATH call
    (without checking any message of the crash), any CHECK failure inside
    the test body would make the test pass.
    
    This CL leverages the fact that in our setup the "death test style" is
    set to "threadsafe" anyway, so the process that is forked for the death
    test just runs the whole test body including the single death test of
    interest, and the parent checks that it indeed crashes. This allows us
    to undo our previous setup and just include death test assertions
    regularly in the test body. By checking that the child process fails
    exactly between two print statements (around the write access) we ensure
    that we observe the crash we intend to observe.
    
    R=jkummerow@chromium.org
    CC=​mpdenton@chromium.org
    
    Bug: v8:11974
    Cq-Include-Trybots: luci.v8.try:v8_mac_arm64_rel_ng
    Cq-Include-Trybots: luci.v8.try:v8_mac_arm64_dbg_ng
    Change-Id: I293079ae2dbcbe154bef91314ed08cab567f4d18
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3151965Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#76814}
    e28f0cc4
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...