• zhengxing.li's avatar
    X87: [compiler] Always pass closure argument to with, catch and block context creation. · e2128e3c
    zhengxing.li authored
      port d3e5db04 (r32336)
    
      original commit message:
      Up until now we sometimes pass Smi 0 around as closure and expect the
      runtime to translate that appropriately. But we need to be careful in
      some places to not confuse the Smi 0 with a real closure. However, we
      could instead just pass the correct closure extracted from the native
      context.
    
      This addresses three long-standing TODOs in the JSTypedLowering pass.
    
      Drive-by-fix: Further unify error message reporting for ToObject (we had
      a special message in case of ToObject error in with context creation).
    
    BUG=
    
    Review URL: https://codereview.chromium.org/1474243002
    
    Cr-Commit-Position: refs/heads/master@{#32356}
    e2128e3c
Name
Last commit
Last update
benchmarks Loading commit data...
build Loading commit data...
docs Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
Makefile.nacl Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...