• Seth Brenith's avatar
    [wasm][arm64] Fix crash on atomic cmpxchg with large offset · e1fff28b
    Seth Brenith authored
    Liftoff can currently run out of registers when compiling an atomic
    compare-exchange instruction. In order to see this crash, the following
    conditions must be met:
    
    - The offset in the instruction doesn't fit in a 12-bit immediate
    - Either FLAG_untrusted_code_mitigations is false, or trap handlers are
      enabled, so that AddMemoryMasking decides to do nothing
    
    The fix proposed in this CL is just to defer allocation of a temporary
    register until after CalculateActualAddress has finished, because it
    might have also needed a temporary register.
    
    Change-Id: I28225614dcdbe2bcc9e52208f1e806baac89c5f1
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2488840
    Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
    Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#70687}
    e1fff28b
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...