• Seth Brenith's avatar
    [wasm][arm64] Fix crash on atomic cmpxchg with large offset · e1fff28b
    Seth Brenith authored
    Liftoff can currently run out of registers when compiling an atomic
    compare-exchange instruction. In order to see this crash, the following
    conditions must be met:
    
    - The offset in the instruction doesn't fit in a 12-bit immediate
    - Either FLAG_untrusted_code_mitigations is false, or trap handlers are
      enabled, so that AddMemoryMasking decides to do nothing
    
    The fix proposed in this CL is just to defer allocation of a temporary
    register until after CalculateActualAddress has finished, because it
    might have also needed a temporary register.
    
    Change-Id: I28225614dcdbe2bcc9e52208f1e806baac89c5f1
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2488840
    Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
    Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#70687}
    e1fff28b
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...