• jgruber's avatar
    [regexp] Add stack check to RegExpExec · e1f676ec
    jgruber authored
    Band-aid fix for infinite recursion in RegExp TFJ builtins.
    
    TFJ builtins don't contain stack checks in general, so any deep
    recursion involving only TFJ builtins can end up overflowing the stack
    and segfaulting on the red area.
    
    RegExp builtins in particular can only build such recursions using
    RegExp.p.exec, and (as far as I can tell) only by modifying the instance
    or prototype, thus hitting the slow path in all builtins.
    
    This CL adds a stack check to RegExpExec, which is the choke point for
    calling exec on slow-mode RegExps.
    
    Bug: v8:7239, chromium:797481
    
    Regression test
    
    Change-Id: I78dbb5f868a775d9697606d513623f912639d7db
    Reviewed-on: https://chromium-review.googlesource.com/856777Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#50511}
    e1f676ec
Name
Last commit
Last update
..
benchmarks Loading commit data...
cctest Loading commit data...
common Loading commit data...
debugger Loading commit data...
fuzzer Loading commit data...
inspector Loading commit data...
intl Loading commit data...
js-perf-test Loading commit data...
memory Loading commit data...
message Loading commit data...
mjsunit Loading commit data...
mkgrokdump Loading commit data...
mozilla Loading commit data...
preparser Loading commit data...
test262 Loading commit data...
unittests Loading commit data...
wasm-spec-tests Loading commit data...
webkit Loading commit data...
BUILD.gn Loading commit data...
bot_default.gyp Loading commit data...
bot_default.isolate Loading commit data...
default.gyp Loading commit data...
default.isolate Loading commit data...
optimize_for_size.gyp Loading commit data...
optimize_for_size.isolate Loading commit data...
perf.gyp Loading commit data...
perf.isolate Loading commit data...