• jgruber's avatar
    [regexp] Add stack check to RegExpExec · e1f676ec
    jgruber authored
    Band-aid fix for infinite recursion in RegExp TFJ builtins.
    
    TFJ builtins don't contain stack checks in general, so any deep
    recursion involving only TFJ builtins can end up overflowing the stack
    and segfaulting on the red area.
    
    RegExp builtins in particular can only build such recursions using
    RegExp.p.exec, and (as far as I can tell) only by modifying the instance
    or prototype, thus hitting the slow path in all builtins.
    
    This CL adds a stack check to RegExpExec, which is the choke point for
    calling exec on slow-mode RegExps.
    
    Bug: v8:7239, chromium:797481
    
    Regression test
    
    Change-Id: I78dbb5f868a775d9697606d513623f912639d7db
    Reviewed-on: https://chromium-review.googlesource.com/856777Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#50511}
    e1f676ec
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...