• Toon Verwaest's avatar
    [maglev] Various regalloc fixes · e16e8d8b
    Toon Verwaest authored
      * Move fixed temporary allocation before arbitrary input allocation,
        so that fixed temporaries don't accidentally clobber the arbitrary
        input register. Now the input allocation will pick a different
        register.
      * For the above, make temporary allocation 'block' the register with a
        sentinel value, rather than marking it free, so that the subsequent
        input allocation knows not to use those registers (including
        spilling into them).
      * Similarly, move arbitrary input allocation after phi resolution when
        allocating control nodes, since phis may have fixed requirements.
      * Allow deopts to spill their inputs if they are not in registers and
        not yet loadable. This is done during the equivalent of input
        allocation for deopts.
      * Allow there to be multiple targets for a single source during gap
        move collection / cycle detection. There can still only be a single
        source per target, therefore there can only be one cycle for each
        connected component -- this is DCHECKed.
      * Make register validation more complete -- also walk the entire
        graph, and check whether value nodes' result register states match
        the current register allocator state.
      * Add much more printing to --trace-maglev-regalloc because these bugs
        ain't easy to debug.
    
    Bug: v8:7700
    Change-Id: Id98259c2920d772ce168bf27497162e78b136f9f
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3714235
    Auto-Submit: Toon Verwaest <verwaest@chromium.org>
    Commit-Queue: Toon Verwaest <verwaest@chromium.org>
    Reviewed-by: 's avatarIgor Sheludko <ishell@chromium.org>
    Commit-Queue: Igor Sheludko <ishell@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#81252}
    e16e8d8b
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
bigint Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
maglev Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sandbox Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
temporal Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...