• Toon Verwaest's avatar
    [maglev] Various regalloc fixes · e16e8d8b
    Toon Verwaest authored
      * Move fixed temporary allocation before arbitrary input allocation,
        so that fixed temporaries don't accidentally clobber the arbitrary
        input register. Now the input allocation will pick a different
        register.
      * For the above, make temporary allocation 'block' the register with a
        sentinel value, rather than marking it free, so that the subsequent
        input allocation knows not to use those registers (including
        spilling into them).
      * Similarly, move arbitrary input allocation after phi resolution when
        allocating control nodes, since phis may have fixed requirements.
      * Allow deopts to spill their inputs if they are not in registers and
        not yet loadable. This is done during the equivalent of input
        allocation for deopts.
      * Allow there to be multiple targets for a single source during gap
        move collection / cycle detection. There can still only be a single
        source per target, therefore there can only be one cycle for each
        connected component -- this is DCHECKed.
      * Make register validation more complete -- also walk the entire
        graph, and check whether value nodes' result register states match
        the current register allocator state.
      * Add much more printing to --trace-maglev-regalloc because these bugs
        ain't easy to debug.
    
    Bug: v8:7700
    Change-Id: Id98259c2920d772ce168bf27497162e78b136f9f
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3714235
    Auto-Submit: Toon Verwaest <verwaest@chromium.org>
    Commit-Queue: Toon Verwaest <verwaest@chromium.org>
    Reviewed-by: 's avatarIgor Sheludko <ishell@chromium.org>
    Commit-Queue: Igor Sheludko <ishell@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#81252}
    e16e8d8b
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.style.yapf Loading commit data...
.vpython Loading commit data...
.vpython3 Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...