• Corentin Pescheloche's avatar
    Reland "[profiler] Surface VM & Embedder State" · e155881f
    Corentin Pescheloche authored
    This is a reland of 2d087f23
    
    The changes are :
    * Fix redundant reinterpret_cast in test file for MSVC failure
    https://crbug.com/v8/12476
    * Fix flaky test
    https://crbug.com/v8/12475
    If a sample is captured during a GC, no embedder context is obtained
    defaulting to EMPTY. This is the expected behavior, made it in clear
    in implementation and in test.
    * Synchronized the embedder context filter behavior with existing
    native context filter.
    
    Original change's description:
    
    > Add APIs to surface VMState and new EmbedderState to CpuProfile samples.
    >
    > EmbedderState:
    > * An EmbedderState is defined as a value uint8_t and a v8::context used
    > for filtering.
    > * EmbedderStates are stack allocated by the embedder, construction and
    > destruction set/unset the state to the isolate thread local top.
    > * A v8::context is used to filter states that are added to a CpuProfile,
    > if the CpuProfile do not have a ContextFilter set or if contexts do not
    > match, state defaults to Empty.
    >
    > * v8:StateTag is already propagated all the way to a Sample, simply add
    > an API to surface it.
    >
    > VMState:
    > Change-Id: I7eed08907360b99b0ad20ddcff59c95c7076c85e
    > Bug: chromium:1263871
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3188072
    > Auto-Submit: Corentin Pescheloche <cpescheloche@fb.com>
    > Reviewed-by: Camillo Bruni <cbruni@chromium.org>
    > Reviewed-by: Dominik Inführ <dinfuehr@chromium.org>
    > Reviewed-by: Igor Sheludko <ishell@chromium.org>
    > Commit-Queue: Camillo Bruni <cbruni@chromium.org>
    > Cr-Commit-Position: refs/heads/main@{#78250}
    
    Bug: chromium:1263871
    Change-Id: Ief891b05da99c695e9fb70f94ed7ebdecc6c3b7b
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3320037
    Auto-Submit: Corentin Pescheloche <cpescheloche@fb.com>
    Reviewed-by: 's avatarCamillo Bruni <cbruni@chromium.org>
    Reviewed-by: 's avatarIgor Sheludko <ishell@chromium.org>
    Reviewed-by: 's avatarDominik Inführ <dinfuehr@chromium.org>
    Commit-Queue: Dominik Inführ <dinfuehr@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#78281}
    e155881f
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.vpython Loading commit data...
.vpython3 Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...