• Jakob Gruber's avatar
    [ic] Refactor unary op assembler implementations · e1427aea
    Jakob Gruber authored
    This CL brings unary op assembler structure closer to that of binary
    ops assemblers:
    
    - Decrement, Increment, Negate call into UnaryOpWithFeedback,
    - which takes lambdas specifying smi, float, and bigint logic.
    - BitwiseNot is different in that it still dispatches using
      TaggedToWOrd32OrBigIntWithFeedback.
    - These methods are all implemented in the (hidden)
      UnaryOpAssemblerImpl class.
    - The header only exposes UnaryOpAssembler with the bare minimum of
      API.
    
    The last point is the remaining major divergence from binary op
    assemblers. I just like how this avoids useless implementation details
    in the header.
    
    Bug: v8:8888
    Change-Id: I0ac4695483950356885301234d58c1900904aa92
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2214830
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Reviewed-by: 's avatarIgor Sheludko <ishell@chromium.org>
    Reviewed-by: 's avatarRoss McIlroy <rmcilroy@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#68004}
    e1427aea
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...