• littledan's avatar
    Construct instances of base class from TypedArray.prototype.subarray · e13f2ff4
    littledan authored
    Previous changes with subclassable builtins and @@species were a bit
    aggressive in making TypedArray.prototype.subarray act like the
    ES2016 specification in terms of returning an instance of the
    subclass as a result. It turns out that Node.js, and extracted
    libraries for the web, subclass TypedArrays but don't expect the
    subclass constructor to be called by subarray. @@species will provide
    an escape hatch, but it has not shipped yet, and will take some time
    for uptake by libraries.
    
    For now, this patch makes TypedArray.prototype.subarray fall back to
    constructing an instance of the parent TypedArray class, such as
    Uint8Array.
    
    R=adamk
    LOG=Y
    BUG=v8:4665
    
    Review URL: https://codereview.chromium.org/1583773005
    
    Cr-Commit-Position: refs/heads/master@{#33312}
    e13f2ff4
Name
Last commit
Last update
benchmarks Loading commit data...
build Loading commit data...
docs Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
Makefile.nacl Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...