• Clemens Backes's avatar
    [base] Fix {StaticCharVector} and add {StaticOneByteVector} · e04eb281
    Clemens Backes authored
    {StaticCharVector}, according to its name, should return a
    {Vector<const char>}. For getting a {Vector<const uint8_t>}, the method
    should be called {StaticOneByteVector}, analog to the
    {OneByteVector} methods that already exist.
    
    Also, {StaticCharVector} is constexpr, but {StaticOneByteVector} cannot
    be, since it contains a {reinterpret_cast}. The same holds for
    {Vector::cast} in general.
    
    This CL
    - changes the return type of {StaticCharVector} to be
      {Vector<const char>},
    - introduces a new {StaticOneByteVector} which returns
      {Vector<const uint8_t>},
    - fixes constexpr annotations at various methods returning {Vector}s,
    - refactors users of {StaticCharVector} to either use
      {StaticOneByteVector} instead, or work on {char} if that makes more
      sense.
    
    R=leszeks@chromium.org
    
    Bug: v8:10426
    Change-Id: I71e336097e41ad30f982aa6344ca3d67b3a01fe3
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2154196
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#67213}
    e04eb281
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...