• Jakob Gruber's avatar
    Improve usability of GraphAssembler's Unreachable() · e02e5107
    Jakob Gruber authored
    Prior to this CL, one had to artificially insert a
    basic-block-terminating node after Unreachable. The common pattern was
    
     Unreachable();
     Goto(&some_label);  // Never reached but generates useless code.
    
    This CL improves usability by automatically merging Unreachable nodes
    to the end node, and terminating current effect/control. The updated
    pattern is just
    
     Unreachable();
    
    or in cases where Turboprop must maintain a schedule:
    
     Unreachable(&some_label);
    
    Bug: v8:8888
    Change-Id: I26a0b11b5e67252a6dc3584ae09ed06370f1eacc
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2362690
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Auto-Submit: Jakob Gruber <jgruber@chromium.org>
    Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
    Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#69531}
    e02e5107
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...