• Georg Neis's avatar
    [modules] Fix mapping of internal status to external status. · e0174631
    Georg Neis authored
    Internally, the module status type has one additional value, namely
    PreInstantiating. I previously mapped this to Instantiating when
    crossing the API boundary but it really should be mapped to
    Uninstantiated. That's because when instantiation fails, typically all
    modules not yet visited will remain in the PreInstantiating state, yet
    they must appear Uninstantiated to the outside.
    
    A relevant test will be added to chromium shortly.
    
    Bug: v8:1569, chromium:748544
    Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng
    Change-Id: Icb33c7f90db5e62375b6c09d14e3d2d5342b0879
    Reviewed-on: https://chromium-review.googlesource.com/586602Reviewed-by: 's avatarAdam Klein <adamk@chromium.org>
    Commit-Queue: Georg Neis <neis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#46911}
    e0174631
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...