• Jakob Kummerow's avatar
    [bigint] Faster parsing from small strings · 7817cf1f
    Jakob Kummerow authored
    This patch significantly speeds up parsing of small BigInts. Its
    primary idea is to move the loop that's iterating over the string
    into the FromStringAccumulator API. That enables using function-
    local variables instead of member fields.
    A second optimization is to use a stack-allocated digit_t[] array
    for small sizes, before falling back to a (comparatively slow)
    std::vector.
    As a particularly fast path, when this stack-allocated storage is
    guaranteed to be enough, we can perform inlined multiply-and-add
    steps directly on that data.
    Finally, this patch changes the conversion of characters to their
    numeric values from computations to a lookup table, which is a bit
    faster for radixes <= 10 (where, in the old code, only one range
    needed to be checked), and a lot faster for radixes > 10.
    
    Bug: v8:11515
    Change-Id: Ifd8ec4799ac34447ba6d4350b7788b559307784c
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3064603
    Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
    Reviewed-by: 's avatarMaya Lekova <mslekova@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#76210}
    7817cf1f
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
bigint Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...