• Shu-yu Guo's avatar
    [shared-struct] Fix external pointers to WaiterQueueNodes · df59f217
    Shu-yu Guo authored
    WaiterQueueNodes as used by JS synchronization primitives are per-main
    thread, and external pointer handles to those nodes are 1-1. That
    1-1-ness is captured by each main thread Isolate having a
    waiter_queue_node_external_pointer_ field.
    
    The current logic is incorrect on unlock paths as the Isolate that
    requested the unlock can point its own
    waiter_queue_node_external_pointer_ to another Isolate's
    WaiterQueueNode. This CL fixes this by having each WaiterQueueNode hold onto its own external pointer handle.
    
    This CL also fixes an embarrassing bug where the WaiterQueueNode was not correctly dequeued on timeout.
    
    Bug: v8:13189, v8:12547
    Change-Id: I8db16ae6d653d2e71989ad003faae20fcee06a25
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3832298
    Commit-Queue: Shu-yu Guo <syg@chromium.org>
    Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
    Reviewed-by: 's avatarSamuel Groß <saelo@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#82601}
    df59f217
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.style.yapf Loading commit data...
.vpython Loading commit data...
.vpython3 Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...