• vogelheim's avatar
    Fix expression positions for for-loops. · de4f3d3e
    vogelheim authored
    FullCodegen generates 2 statement positions for the loop init block, like so:
    
      for(var i = 0; i....
          ^   ^
    
    This change removes the first of those, updates unit tests,
    and removes text expectations for Ignition.
    
    ---
    An alternative would be to emulate the existing behaviour in Ignition, but:
    - The new behaviour seems more logical,
    - Ignition generates no bytecodes for the 'var', meaning there is no code position to attach the break position to.
    
    BUG=v8:4690
    LOG=Y
    
    Review URL: https://codereview.chromium.org/1784883002
    
    Cr-Commit-Position: refs/heads/master@{#34717}
    de4f3d3e
Name
Last commit
Last update
benchmarks Loading commit data...
build Loading commit data...
docs Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
Makefile.nacl Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...