• Leszek Swirski's avatar
    [ast] Allocate cons strings on-demand · ddca3606
    Leszek Swirski authored
    Remove AstConsString "internalization", and instead make the conversion
    to heap String be on-demand with an Allocate method. We never actually
    need the heapified cons string more than once, so there's no need to do
    the internalization walk or do the next/string union dance in the
    AstConsString class.
    
    This also allows us to specify how we want to allocate the String at the
    call site. In particular, it allows us to allocate a flat SeqString rather
    rather than a ConsString. This allows us to avoid allocating ConsStrings
    which will just be passed to a flatten call, and especially avoid
    allocating dead ConsStrings in the off-thread old space.
    
    Bug: chromium:1011762
    Bug: chromium:1043168
    Change-Id: Id851f2f7529d92ad7e5388eb22823fd6d1959cd0
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2020953Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
    Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
    Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#66042}
    ddca3606
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...