• Seth Brenith's avatar
    Always emit unconditional jump in binary-search switch · dd9d4c96
    Seth Brenith authored
    We probably expect a binary-search switch to take log(n) time in all
    cases, but there is currently a possibility of that expectation being
    broken. I'm not aware of any place where this actually happens, but if
    the default handler immediately follows the switch dispatch block in
    assembly order, then unconditional jump instructions for that handler
    would be omitted. This omission could cause linear execution time, where
    every case is checked before falling through to the default handler.
    
    This change introduces a new function to emit an unconditional jump
    instruction regardless of whether the target is the following block, and
    uses that new function when generating a binary-search switch to ensure
    consistently log(n) behavior.
    
    Change-Id: I5cab86fd66386762519035410e3b532dc6fd764c
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3335222Reviewed-by: 's avatarNico Hartmann <nicohartmann@chromium.org>
    Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
    Cr-Commit-Position: refs/heads/main@{#78370}
    dd9d4c96
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
bigint Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
security Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
temporal Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...