• Jakob Gruber's avatar
    Reland "[snapshot] Align internal snapshot data" · dd8e820c
    Jakob Gruber authored
    This is a reland of 4f9d7a94
    
    Original change's description:
    > [snapshot] Align internal snapshot data
    >
    > When the snapshot blob is not aligned properly, loading it can cause a
    > crash on platforms such as arm.
    >
    > This was exposed by a SIGBUS/BUS_ADRALN crash on arm when accessing
    > the blob_data symbol (declared as a byte array) through a reinterpret
    > cast to uintptr_t in an internal snapshot build.
    >
    > Thanks to florian.dold@gmail.com for the initial patch.
    >
    > Bug: v8:9171
    > Change-Id: I99b071dec3733416f2f01b58a770e30d8f2dcdf2
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1582402
    > Commit-Queue: Dan Elphick <delphick@chromium.org>
    > Auto-Submit: Jakob Gruber <jgruber@chromium.org>
    > Reviewed-by: Dan Elphick <delphick@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#61000}
    
    Tbr: delphick@chromium.org
    Bug: v8:9171
    Change-Id: I36f53647ff5c45bcc512147f082fdd069723175d
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1587377Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#61062}
    dd8e820c
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...