• littledan's avatar
    Filter out synthetic variables from with scopes · dcd61b90
    littledan authored
    This patch ensures that variables like .new_target aren't overwritable
    using with scopes. It does this by ensuring that scope analysis does
    not consider with scopes (or eval scopes) for such 'synthetic variables',
    similarly to how the 'this' variable was already handled.
    The patch also adds a DCHECK for the dynamic parallel to this case,
    replacing a previous unreachable path for a particular instance.
    
    BUG=v8:5405
    
    Review-Url: https://codereview.chromium.org/2353623002
    Cr-Commit-Position: refs/heads/master@{#39567}
    dcd61b90
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...