• Seth Brenith's avatar
    [tools] Add in-object properties to debug_helper · dcb828b4
    Seth Brenith authored
    Until now, the in-object properties on JSObject have been invisible to
    tools using the postmortem debugging library. With this change, those
    tools will get enough information to show a flat list of property
    values. This is still less powerful than the runtime printers, which can
    show the corresponding key for each value, but it's a big step up from
    manually inspecting memory.
    
    This change basically requires a reimplementation of
    Map::GetInObjectProperties for postmortem debugging. I'm not
    enthusiastic about duplicating this logic, but it's pretty small and I
    don't see any good alternatives.
    
    As a drive-by cleanup, I moved some inline string literals into a batch
    of constexpr char arrays.
    
    Bug: v8:9376
    Change-Id: Ia24c05f6e823086babaa07882d0d320ab9a225db
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1930174Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
    Cr-Commit-Position: refs/heads/master@{#65183}
    dcb828b4
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...