• Clemens Backes's avatar
    [wasm][debug] Do not install debug code when tiered up · dc318df3
    Clemens Backes authored
    If the debugger is disabled for an isolate, we first remove all
    breakpoints for that isolate, and then tier up the module (if there is
    no other isolate that keeps it tiered down).
    During the first step, functions might get recompiled since the
    set breakpoints change. This is not needed in case we will tier-up the
    module afterwards anyway. It also triggers a DCHECK if we reinstall
    debugging code even though the module is already marked "tiered up".
    
    This CL avoids the installation of debugging if the module is not tiered
    down, and also slightly modified the condition for installing new code
    when tiered-up (to allow overwriting debugging code with non-debugging
    code even if it's the same tier).
    
    R=thibaudm@chromium.org
    
    Bug: chromium:1228628
    Change-Id: I83828d4186e299f779a858006eafa3dbc7966c35
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3026707Reviewed-by: 's avatarThibaud Michaud <thibaudm@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#75722}
    dc318df3
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...