• yangguo's avatar
    Serializer: fix false negative in hashmap lookups. · dbecf20d
    yangguo authored
    If we use HashMap::Lookup with insert=true, the returned entry may have
    NULL as value. This could either mean that the value is 0, or that the
    entry has just been inserted. This ambiguity can cause false negatives
    in PartialCacheIndexMap::LookupOrInsert.
    
    Also fix a TODO.
    
    R=vogelheim@chromium.org
    
    Review URL: https://codereview.chromium.org/974273002
    
    Cr-Commit-Position: refs/heads/master@{#26994}
    dbecf20d
Name
Last commit
Last update
benchmarks Loading commit data...
build Loading commit data...
include Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
Makefile.nacl Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...