• Shu-yu Guo's avatar
    [weakrefs] Port FinalizationRegistry cleanup loop to Torque · dbbaccca
    Shu-yu Guo authored
    To avoid shrinking the unregister token map on each pop of the cleared
    cell list, the Torque implementation of the cleanup loop avoids
    shrinking the map until the end of the loop.
    
    To support that, PopClearedCellHoldings is refactored to the Torque
    PopClearedCell which calls the
    JSFinalization::RemoveCellFromUnregisterTokenMap and the runtime
    ShrinkFinalizationRegistryUnregisterTokenMap. The former cannot GC is
    and is implemented in CSA as a fast C call. The latter can GC and is a
    runtime call.
    
    This also incidentally makes uses of FinalizationRegistry without
    unregister token a fast path that doesn't have to leave Torque.
    
    Bug: v8:8179
    Change-Id: Ia0c3c5800d26e31319a818f164f6bd3267355aa6
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2137950
    Commit-Queue: Shu-yu Guo <syg@chromium.org>
    Reviewed-by: 's avatarMarja Hölttä <marja@chromium.org>
    Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
    Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#67161}
    dbbaccca
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...