• Benoît Lizé's avatar
    [heap/cppgc] Disable guard pages on ARM64 macOS · 8f3c3419
    Benoît Lizé authored
    Guard pages are 4k areas at the beginning and end of each oilpan page
    (128kiB) which are meant to be inaccessible. However on ARM64 macOS, the
    OS page size is 16kiB, meaning that these are not inaccessible. But we
    do pay for these, as they are part of the first and last OS
    page. Meaning that we effectively waste 2 * 4kiB = 6.25% of each Oilpan
    page.
    
    Since these are not serving their purpose, disable them on this
    platform. Another fix could be to make the guard page 16kiB, but given
    that the entire oilpan page is 128kiB, this may have adverse effects on
    e.g. fragmentation.
    
    Note that this doesn't regress security, as the regions were never
    protected to begin with on this platform.
    
    Bug: chromium:1298417
    Change-Id: Iad5d05670962780e6d1eeab2bb8a331deb7aa1f3
    Cq-Include-Trybots: luci.v8.try:v8_linux_arm64_rel_ng
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3471558Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
    Commit-Queue: Benoit Lize <lizeb@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#79151}
    8f3c3419
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
assembler Loading commit data...
base Loading commit data...
codegen Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
date Loading commit data...
debug Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
heap Loading commit data...
interpreter Loading commit data...
libplatform Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parser Loading commit data...
profiler Loading commit data...
regexp Loading commit data...
regress Loading commit data...
runtime Loading commit data...
sandbox Loading commit data...
strings Loading commit data...
tasks Loading commit data...
torque Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
BUILD.gn Loading commit data...
DEPS Loading commit data...
avoid-windows-h-includes.cc Loading commit data...
run-all-unittests.cc Loading commit data...
test-helpers.cc Loading commit data...
test-helpers.h Loading commit data...
test-utils.cc Loading commit data...
test-utils.h Loading commit data...
testcfg.py Loading commit data...
unittests.status Loading commit data...