• Yu Yin's avatar
    [mips][counters] Introduce proper bottleneck for FunctionCallback. · dadb59eb
    Yu Yin authored
    Port ea420655 https://crrev.com/c/1651470
    
    Original Commit Message:
    
        API calls made via the CallApiCallback builtin, which is used from the
        ICs and optimized code, are currently misattributed to the wrong counter
        InvokeFunctionCallback instead of FunctionCallback. In addition we don't
        use the C trampoline when only runtime call stats are enabled, but the
        Chrome DevTools profiler is not active, which means that these calls
        will not be attrituted properly at all, and that had to be worked around
        using all kinds of tricks (i.e. disabling fast-paths in ICs when RCS is
        active and not inlining calls/property accesses into optimized code
        depending on the state of RCS).
    
        All of this was really brittle and only due to the fact that the central
        builtin didn't properly check for RCS (in addition to checking for the
        CDT profiler). With this fix it's now handled in a central place and
        attributed to the correct category, so user code doesn't need to worry
        about RCS anymore and can just call straight into the fast-path.
    
        core hand-written native code with the API callback logic.
    
    Change-Id: I6bcc8c4d7f4642381803a8b6c8282ceb8f3d056c
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1659988
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Reviewed-by: 's avatarBenedikt Meurer <bmeurer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#62163}
    dadb59eb
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...