• jacob.bramley@arm.com's avatar
    A64: Fix r19474: Tidy up Push and Pop TODOs. · d9b31caa
    jacob.bramley@arm.com authored
    This fixes some snapshot=off, debug-mode regressions.
    
      - Call CheckConstPool when entering InsturctionAccurateScopes. This
        fixes a problem in PushMultipleTimes where 'count' is very high.
        Each call to PushHelper starts an InstructionAccurateScope
        immediately after the last one finishes, with no opportunity for the
        constant pool to be generated.
    
      - Temporarily disable AssertStackConsistency in PrepareForPush. This
        assertion seems to push the code size too far, and several cctests
        (intermittently) fail due to buffer size limitations. I would like
        to renable this assertion later.
    
    BUG=
    R=ulan@chromium.org
    
    Review URL: https://codereview.chromium.org/172453002
    
    git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19491 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
    d9b31caa
Name
Last commit
Last update
benchmarks Loading commit data...
build Loading commit data...
include Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
AUTHORS Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
Makefile.nacl Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...