• bmeurer's avatar
    Revert "[turbofan] Avoid going through ArgumentsAdaptorTrampoline for CSA/C++ builtins." · d98dfd8b
    bmeurer authored
    This reverts commit 9df5674b because it
    is not compatible with the way that Array.prototype.reduceRight and
    Array.prototype.reduce deal with optional parameters at this point (i.e.
    parameters where the behavior is different depending on whether the
    parameter was skipped or undefined was passed).
    
    In general, it might be better to not adapt arguments for builtins with
    optional paramters, that are likely skipped, for example as in
    Object.create or Array.prototype.reduce. Since that will require
    arguments adaptor frames for normal calls, especially from baseline
    code. Instead it might make sense to use the variadic arguments support
    in the CodeStubAssembler instead to avoid the arguments adaptor in all
    cases (not only when called from TurboFan optimized code).
    
    BUG=v8:5267,chromium:709782,chromium:707992,chromium:708282,chromium:708599,chromium:709173,chromium:709747,chromium:707065,chromium:710417
    TBR=danno@chromium.org
    
    Review-Url: https://codereview.chromium.org/2817653002
    Cr-Commit-Position: refs/heads/master@{#44593}
    d98dfd8b
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...