• Seth Brenith's avatar
    Add verifier for retaining paths in heap snapshots · d937a0bb
    Seth Brenith authored
    The web app owner who notified me about bugs v8:12112 and v8:12126 asked
    me a reasonable question: "how am I ever supposed to trust the retaining
    paths in the devtools, if the heap snapshot is generated by a different
    component than the actual marking code?". This change is my attempt to
    answer that question. If verification is enabled, the heap snapshot
    generator will visit each heap object with a realistic marking visitor
    to find all references from that object. It will then check that those
    references match the HeapGraphEdges in the snapshot.
    
    I also considered the idea that we could collect retaining information
    during the last GC cycle before taking the heap snapshot, or during an
    extra GC cycle immediately after. However, running the full GC provides
    the embedder with the opportunity to run arbitrary code (including JS)
    both before and after PerformGarbageCollection, so there is no clear
    guarantee that the heap state during the snapshot actually matches the
    heap state during marking.
    
    Bug: v8:12112, v8:12126
    Change-Id: Id29e75ecf9eee19e35daedbdb4a3e1df64785380
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3299590Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
    Reviewed-by: 's avatarCamillo Bruni <cbruni@chromium.org>
    Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
    Cr-Commit-Position: refs/heads/main@{#78952}
    d937a0bb
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.style.yapf Loading commit data...
.vpython Loading commit data...
.vpython3 Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...