• jameslahm's avatar
    [d8] Don't call WaitForRunningWorkers in quit() · d8c9b089
    jameslahm authored
    There are problems calling WaitForRunningWorkers when we
    call quit().
    First, suppose the main thread first calls quit(),
    and the worker thread calls quit() after the main
    thread calls quit(), then sched_yield to wait for
    quit_once_ updated to ONCE_STATE_DONE. However
    the main thread is WaitForRunningWorkers to wait
    for the worker thread to join, thus causing deadlock.
    
    Second, suppose the worker thread calls quit() and empty
    the running_workers_ by WaitForRunningWorkers, then
    the main thread calls `onExit(isolate, true)` to dispose
    the platform and other global data, which will crash other
    running workers.
    
    Bug: v8:12219
    Change-Id: I333e5aad431daefb1c163f69e66d8e9d5e9bf754
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3518908Reviewed-by: 's avatarMarja Hölttä <marja@chromium.org>
    Commit-Queue: Marja Hölttä <marja@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#79525}
    d8c9b089
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
bigint Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
maglev Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sandbox Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
temporal Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...