• Clemens Backes's avatar
    [Liftoff] Clean up implementation of AtomicStore · d8bb229d
    Clemens Backes authored
    As discussed offline, the current implementation implement each
    situation separately. I think we can simplify the code a lot by sharing
    code between the different paths.
    This CL does that by
    1) implementing the kI64Store case separately, because it does not have
       all the register contraints that the others have, and
    2) moving all logic to ensure that the {src} register is usable before
       the switch, such that it's shared by all the compare-exchange cases.
    
    As a side produce, this also fixes issue 1045225, because for i64 stores
    which actually only use the lower half of {src}, only that half will be
    pinned.
    
    R=ahaas@chromium.org
    
    Bug: chromium:1045225, v8:10108
    Change-Id: I0be025b9706d563835ae6337d45b88e0233eacad
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2029414Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#66062}
    d8bb229d
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...