• Clemens Backes's avatar
    [Liftoff] Clean up implementation of AtomicStore · d8bb229d
    Clemens Backes authored
    As discussed offline, the current implementation implement each
    situation separately. I think we can simplify the code a lot by sharing
    code between the different paths.
    This CL does that by
    1) implementing the kI64Store case separately, because it does not have
       all the register contraints that the others have, and
    2) moving all logic to ensure that the {src} register is usable before
       the switch, such that it's shared by all the compare-exchange cases.
    
    As a side produce, this also fixes issue 1045225, because for i64 stores
    which actually only use the lower half of {src}, only that half will be
    pinned.
    
    R=ahaas@chromium.org
    
    Bug: chromium:1045225, v8:10108
    Change-Id: I0be025b9706d563835ae6337d45b88e0233eacad
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2029414Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#66062}
    d8bb229d
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...