• Clemens Backes's avatar
    [wasm] Split decoding into individual functions · d8a32a96
    Clemens Backes authored
    Instead of having a loop with one big switch for handling the different
    opcodes, split the decoding into one handler per opcode and call them
    via an opcode handler table.
    The compiler will generate similar code for this new approach (the big
    switch is also compiled into a table lookup and an indirect jump). The
    main difference is that it's now calls instead of jumps. This has a
    slight performance impact, but allows to look at the decoding logic of
    individual opcodes in isolation and see optimization opportunities much
    easier. It also allows spot very easily in profilers on which opcodes
    most time is spent.
    
    The different opcode handlers are still implemented via the same switch
    as before, but since the opcode is a template argument (hence static)
    the compiler will eliminate the switch and generate the small handlers
    we want.
    I plan to actually remove the switch and break up the big generic
    {DecodeOp} method into one method per opcode.
    
    R=thibaudm@chromium.org
    
    Bug: v8:10576
    Change-Id: Ic2c1e2fe5e98df52a7079ace305cf77340dcbf35
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2249664Reviewed-by: 's avatarThibaud Michaud <thibaudm@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#68403}
    d8a32a96
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...