• Clemens Backes's avatar
    [wasm] Split decoding into individual functions · d8a32a96
    Clemens Backes authored
    Instead of having a loop with one big switch for handling the different
    opcodes, split the decoding into one handler per opcode and call them
    via an opcode handler table.
    The compiler will generate similar code for this new approach (the big
    switch is also compiled into a table lookup and an indirect jump). The
    main difference is that it's now calls instead of jumps. This has a
    slight performance impact, but allows to look at the decoding logic of
    individual opcodes in isolation and see optimization opportunities much
    easier. It also allows spot very easily in profilers on which opcodes
    most time is spent.
    
    The different opcode handlers are still implemented via the same switch
    as before, but since the opcode is a template argument (hence static)
    the compiler will eliminate the switch and generate the small handlers
    we want.
    I plan to actually remove the switch and break up the big generic
    {DecodeOp} method into one method per opcode.
    
    R=thibaudm@chromium.org
    
    Bug: v8:10576
    Change-Id: Ic2c1e2fe5e98df52a7079ace305cf77340dcbf35
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2249664Reviewed-by: 's avatarThibaud Michaud <thibaudm@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#68403}
    d8a32a96
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...