• jgruber's avatar
    [builtins] Clear RelocInfo for off-heap trampolines · d854d351
    jgruber authored
    For technical reasons, we used to serialize off-heap trampolines with a
    RelocInfo containing a single OFF_HEAP_TARGET entry. This RelocInfo was
    never needed at runtime. It also ended up being somewhat misleading
    because printing an embedded code object would show the OFF_HEAP_TARGET
    entry (belonging to the trampoline) at the first 'real' instruction.
    
    With this CL, we explicitly serialize an empty byte array as the reloc
    info for each off-heap trampoline, i.e. the snapshot will never contain
    such off-heap target reloc infos.
    
    Bug: v8:6666, v8:7969
    Change-Id: If6fa85a438d093ed5dcea07ce0de1db49a224d28
    Reviewed-on: https://chromium-review.googlesource.com/1146643
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#54786}
    d854d351
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...