• Marja Hölttä's avatar
    [heap] Fix iterating uninitialized TransitionArrays. · d82e8f37
    Marja Hölttä authored
    This pattern seems to reoccur in the code:
    
    Handle<TransitionArray> array = TransitionArray::Allocate(...);
    <something that causes allocation>
    // Fill up the array
    array->set(...);
    
    If the allocation causes GC, we try to iterate the TransitionArrray
    in MarkCompactCollector::ClearFullMapTransitions, and that crashes because it
    expects the TransitionArray to contain handlers (not undefined).
    
    This bug is present e.g., in TransitionAccessor::EnsureHasFullTransition.
    
    BUG=v8:7308
    
    Change-Id: I306204fc27d62041801427c466c82d1d9df1bf0c
    Reviewed-on: https://chromium-review.googlesource.com/997493
    Commit-Queue: Marja Hölttä <marja@chromium.org>
    Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#52386}
    d82e8f37
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...