• Jakob Gruber's avatar
    [compiler] Use StateValuesAccess to access frame state parameters · 0ef84f99
    Jakob Gruber authored
    FrameState parameters must not be iterated directly since parameters
    can be encoded into StateValues (i.e. parameter i is not necessarily
    InputAt(i)). Instead, they should be accessed through the
    StateValuesAccess helper class.
    
    One example:
    
     82: StateValues[sparse:^^^^^^](81, 31, 32, 33, 34, 35)
      81: StateValues[sparse:^^^^^^^^](110, 24, 25, 26, 27, 28, 29, 30)
      31: NumberConstant[8]
      32: NumberConstant[9]
      33: NumberConstant[10]
      34: NumberConstant[11]
      35: NumberConstant[13]
    
    Here, node 81 holds multiple parameters. These are properly iterated
    by the StateValuesAccess class.
    
    Bug: chromium:1166136
    Change-Id: I12725f83994e1c05571bcba153ff45154b16d93f
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2625879
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
    Auto-Submit: Jakob Gruber <jgruber@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#72126}
    0ef84f99
Name
Last commit
Last update
..
benchmarks Loading commit data...
cctest Loading commit data...
common Loading commit data...
debugger Loading commit data...
debugging Loading commit data...
fuzzer Loading commit data...
fuzzilli Loading commit data...
inspector Loading commit data...
intl Loading commit data...
js-perf-test Loading commit data...
memory Loading commit data...
message Loading commit data...
mjsunit Loading commit data...
mkgrokdump Loading commit data...
mozilla Loading commit data...
test262 Loading commit data...
torque Loading commit data...
unittests Loading commit data...
wasm-api-tests Loading commit data...
wasm-js Loading commit data...
wasm-spec-tests Loading commit data...
webkit Loading commit data...
BUILD.gn Loading commit data...
OWNERS Loading commit data...