• jgruber's avatar
    [regexp] Fix invalid lastIndex handling in RegExp.p[@@replace] · d74a9fd5
    jgruber authored
    The RegExp replace implementation is a bit of a mess. Here, we first
    try to handle parts of RegExp.p.exec, and then call directly into the
    raw irregexp code (skipping RegExp.p.exec).
    
    We got parts of this wrong: when lastIndex > string.length and the
    regexp instance is sticky, two things should happen. 1. The match
    should fail, and 2. lastIndex should be reset to 0. On the fast path,
    we did the latter but not the former, instead running exec with a
    lastIndex of 0.
    
    This CL omits the irregexp call in this case, and defaults to a failed
    match instead.
    
    Bug: chromium:875493
    Change-Id: I8c959610d267575e37686076a3fd5dfde322f0ca
    Reviewed-on: https://chromium-review.googlesource.com/1180889
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Reviewed-by: 's avatarMathias Bynens <mathias@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#55207}
    d74a9fd5
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...