• Benedikt Meurer's avatar
    Reland "[turbofan] Consistently use String feedback for JSAdd." · d6e2398a
    Benedikt Meurer authored
    This is a reland of d504203e
    
    Original change's description:
    > [turbofan] Consistently use String feedback for JSAdd.
    > 
    > Currently we didn't always consistently use the String feedback on
    > JSAdd, but only if JSTypedLowering would already figure out statically
    > that one of the inputs is already a String. That leads to some odd
    > performance cliffs, as highlighted in the referenced bug.
    > 
    > This CL fixes the JSTypedLowering::ReduceJSAdd to always bake in the
    > String feedback. This improves the relevant performance tests from the
    > bug from
    > 
    >   console.timeEnd: Runtime join3, 967.512000
    >   console.timeEnd: Runtime join, 1004.599000
    >   console.timeEnd: Runtime join3, 1124.764000
    >   console.timeEnd: Runtime join, 966.164000
    >   console.timeEnd: Runtime join3, 1145.296000
    >   console.timeEnd: Runtime join, 966.176000
    >   console.timeEnd: Runtime join3, 1145.272000
    >   console.timeEnd: Runtime join, 931.266000
    > 
    > to
    > 
    >   console.timeEnd: Runtime join3, 903.050000
    >   console.timeEnd: Runtime join, 856.509000
    >   console.timeEnd: Runtime join3, 945.144000
    >   console.timeEnd: Runtime join, 840.038000
    >   console.timeEnd: Runtime join3, 927.965000
    >   console.timeEnd: Runtime join, 841.263000
    >   console.timeEnd: Runtime join3, 929.342000
    >   console.timeEnd: Runtime join, 858.143000
    > 
    > which corresponds to an 8-18% improvement.
    > 
    > Bug: v8:7415
    > Change-Id: I62e008298e4ee0864885b37817c91d055acf2a09
    > Reviewed-on: https://chromium-review.googlesource.com/936643
    > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
    > Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#51551}
    
    Bug: v8:7415
    Change-Id: Idbc889dc070f764dacf3bf535e41d0e66ab09bea
    Reviewed-on: https://chromium-review.googlesource.com/964421Reviewed-by: 's avatarBenedikt Meurer <bmeurer@chromium.org>
    Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#51965}
    d6e2398a
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...