• Clemens Backes's avatar
    [wasm] Split decoder functions · d696c37d
    Clemens Backes authored
    Instead of having one method with a big switch, and specializing that
    method for each single opcode, we now have one proper method per opcode.
    This makes the code way more readable, and also reduces the compile time
    of liftoff-compiler.cc significantly.
    
    Unfortunately, we cannot use template specializations for this, since
    GCC does not support specializing the methods within an unspecialized
    templated class.
    Hence, we need to have another dispatch per opcode when generating the
    opcode handler table. I left a comment explaining why we do it this way.
    The upside of this is that we get nicer method names.
    
    R=thibaudm@chromium.org
    
    Bug: v8:10576
    Change-Id: I8c7026177490893711c999217eeb1e4f2fbb5e36
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2282533
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Reviewed-by: 's avatarThibaud Michaud <thibaudm@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#68732}
    d696c37d
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...