• Dan Elphick's avatar
    [builtins] Fix Array.of crashes by setting length correctly · d5dca89b
    Dan Elphick authored
    Before we can set the length of the created array in CSA, first check
    that it's possible and will do what we want. I.e. check
    a) that the length is writable
    b) the backing store is not copy-on-write and
    c) the old length is not greater than the new length (as otherwise later
    insertion past the end could restore values from the original
    constructor).
    
    If not then fall back on Runtime::kSetProperty.
    
    Bug: chromium:804177
    Change-Id: Id0e452f9d160704bbd71e87a075ba4e3983729a7
    Reviewed-on: https://chromium-review.googlesource.com/880922
    Commit-Queue: Dan Elphick <delphick@chromium.org>
    Reviewed-by: 's avatarRoss McIlroy <rmcilroy@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#50818}
    d5dca89b
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...