• Dominik Inführ's avatar
    [codegen, heap] Improve TimeToSafepoint for concurrent compilation · d5416b99
    Dominik Inführ authored
    TimeToSafepoint is the time needed for all background threads to enter
    a safepoint after the GC was started on the main thread. This CL
    improves that metric during concurrent compilation to bytecode by doing:
    
    1) Park the LocalIsolate during
       InterpreterCompilationJob::ExecuteJobImpl. There are no concurrent
       heap accesses happening while generating bytecode for now. So instead
       of manually placing Safepoint() invocations in the code, simply park
       the local isolate.
    2) Destroy the LocalIsolate before the ReleaseParser operation. I've
       seen this take around 2ms, which regressed TimeToSafepoint a lot.
    3) Add explicit safepoints to concurrent allocations. This covers the
       rest of the code and from what I've seen so far this is good enough
       to keep TimeToSafepoint around a few microseconds.
    
    I've still seen TimeToSafepoint events with 20-80 microseconds but those
    were quite rare and always seemed to be related to Turbofan.
    
    AsLocalIsolate() is necessary in generic code to convert both Isolate
    and LocalIsolate to LocalIsolate.
    
    Bug: v8:10315
    Change-Id: Idaf9f04ffdf850d0ab0081ec372cc384a9fe7ef9
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2663159Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
    Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
    Commit-Queue: Dominik Inführ <dinfuehr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#72618}
    d5416b99
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...