• jochen@chromium.org's avatar
    Use abstract configurations to switch between opt debug settings · d426cd10
    jochen@chromium.org authored
    The problem is that conditions are evaluated before configuration inheritance is resolved, so we can't just define a configuration like this:
    
    'Optdebug': {
      'inherits_from': ['Debug'],
      'variables': {
        'v8_optimized_debug': 2,
      }
    }
    
    Instead, we have to put the different settings depending on the optimization level into separate configurations, and use conditions inside the concrete configurations to inherit from the correct base class.
    
    Common settings go in the base configuration DebugBaseCommon, and v8_optimized_debug dependent settings go into DebugBase{0,1,2}
    
    The new Debug configuration inherits from DebugBaseCommon and DebugBase<(v8_optimized_debug), while the new configuration Optdebug inherits from DebugBaseCommon and DebugBase2.
    
    BUG=v8:3252
    R=machenbach@chromium.org, jkummerow@chromium.org
    LOG=n
    
    Review URL: https://codereview.chromium.org/224443003
    
    git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20605 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
    d426cd10
Name
Last commit
Last update
benchmarks Loading commit data...
build Loading commit data...
include Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
AUTHORS Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
Makefile.nacl Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...