• Ng Zhi An's avatar
    Reland "[liftoff] Use stack slot offsets instead of indices" · d3cd2702
    Ng Zhi An authored
    This is a reland of 20727725
    
    The fix is in liftoff-assembler-arm64.h in FillStackSlotsWithZero,
    in the else case for bigger counts to fill, the argument passed to Sub
    was incorrect. We were passing offset relative to first slot, but it
    should be offset relative to instance, so there is an off by 1 slot error
    when zeroing, and ended up zeroing the stack slot holding instance.
    
    Original change's description:
    > [liftoff] Use stack slot offsets instead of indices
    >
    > Spill/fill now take offsets instead of indices. We provide a
    > helper, GetStackOffsetFromIndex, for callers. This is currently only
    > useful while slot sizes are still fixed to 8 bytes.
    >
    > StackTransferRecipe's RegisterLoad now works in terms of offset.
    >
    > LiftoffStackSlots work in terms of offset as well.
    >
    > TransferStackSlot currently still works in terms of indicies, but can be
    > converted to use offsets in a subsequent change.
    >
    > Bug: v8:9909
    > Change-Id: If54fb844309bdfd641720d063135dd59551813e0
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1922489
    > Reviewed-by: Clemens Backes <clemensb@chromium.org>
    > Commit-Queue: Zhi An Ng <zhin@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#65049}
    
    Bug: v8:9909
    Change-Id: I311da9d3bb1db8faf8693079177c77a7b3754243
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1925131Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
    Commit-Queue: Zhi An Ng <zhin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#65107}
    d3cd2702
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...