• Caitlin Potter's avatar
    [esnext] implement spec change to TaggedTemplate callsite caching · d3ca0d00
    Caitlin Potter authored
    Implements the change outlined in https://github.com/tc39/ecma262/pull/890,
    which has been ratified and pulled into the specification. In particular,
    template callsite objects are no longer kept in a global, eternal Map, but
    are instead associated with their callsite, which can be collected. This
    prevents a memory leak incurred by TaggedTemplate calls.
    
    Changes, summarized:
    
        - Remove the TemplateMap and TemplateMapShape objects, instead caching
          template objects in the feedback vector.
        - Remove the `hash` member of TemplateObjectDescriptor, and the Equals
          method (used by TemplateMap)
        - Add a new FeedbackSlotKind (kTemplateObject), which behaves similarly
          to FeedbackSlotKind::kLiteral, but prevents eval caching. This ensures
          that a new feedback vector is always created for eval() containing tagged
          templates, even when the CompilationCache is used.
        - GetTemplateObject bytecode now takes a feedback index, and only calls
          into the runtime if the feedback is Smi::kZero (uninitialized).
    
    BUG=v8:3230, v8:2891
    R=littledan@chromium.org, yangguo@chromium.org, bmeurer@chromium.org,
    rmcilroy@chromium.org
    
    Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
    Change-Id: I7827bc148d3d93e2b056ebf63dd624da196ad423
    Reviewed-on: https://chromium-review.googlesource.com/624564
    Commit-Queue: Caitlin Potter <caitp@igalia.com>
    Reviewed-by: 's avatarBenedikt Meurer <bmeurer@chromium.org>
    Reviewed-by: 's avatarRoss McIlroy <rmcilroy@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#51248}
    d3ca0d00
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...