• Clemens Backes's avatar
    [codegen] Simplify definition of signatures · d38f84ac
    Clemens Backes authored
    Liftoff defines many signatures of fixed size. This is currently done by
    defining a fixed-size array on the stack, and then using this in the
    signature definition. This is cumbersome and hard to read, since the
    array contains return types and parameter types, and only the signature
    definition separates the two. But also the order of those two sizes in
    the signature is non-obvious and easy to get wrong.
    
    This CL introduces a helper to define fixed-size signatures in a
    "builder style", i.e. parameters and return types can be added
    separately. The fixed-size array will be contained in the returned
    class, so it will still be stack-allocated like before. The copies to
    iteratively build up this array should be completely eliminated by the
    compiler, so the binary code should look exactly the same.
    
    R=ahaas@chromium.org
    
    Bug: v8:11384
    Change-Id: I167830d6c3429f535b7d1241920730498a9bb4c1
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2747505
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#73341}
    d38f84ac
Name
Last commit
Last update
.github Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...